MongoBleed Explained Simply

(bigdata.2minutestreaming.com)

120 points | by todsacerdoti 6 hours ago

14 comments

  • vivzkestrel 6 minutes ago
    is it true that ubisoft got hacked and 900GB of data from their database was leaked due to mongobleed, i am seeing a lot of posts on social media under the #ubisoft tags today. can someone on HN confirm?
  • kentonv 4 hours ago
    A few years back I patched the memory allocator used by the Cloudflare Workers runtime to overwrite all memory with a static byte pattern on free, so that uninitialized allocations contain nothing interesting.

    We expected this to hurt performance, but we were unable to measure any impact in practice.

    Everyone still working in memory-unsafe languages should really just do this IMO. It would have mitigated this Mongo bug.

    • cperciva 53 minutes ago
      A few years back I patched the memory allocator used by the Cloudflare Workers runtime to overwrite all memory with a static byte pattern on free, so that uninitialized allocations contain nothing interesting.

      Note that many malloc implementations will do this for you given an appropriate environment, e.g. setting MALLOC_CONF to opt.junk=free will do this on FreeBSD.

    • MuffinFlavored 14 minutes ago
      > OpenBSD uses 0xdb to fill newly allocated memory and 0xdf to fill memory upon being freed. This helps developers catch "use-before-initialization" (seeing 0xdb) and "use-after-free" (seeing 0xdf) bugs quickly.

      Looks like this is the default in OpenBSD.

    • tombert 3 hours ago
      You know, I never even considered doing that but it makes sense; whatever overhead that's incurred by doing that static byte pattern is still almost certainly minuscule compared to the overhead of something like a garbage collector.
      • ddtaylor 2 hours ago
        IMO the tradeoff that is important here is a few microseconds of time sanitizing the memory saves the millions of dollars of headache when memory unsafe languages fail (which happens regularly)
        • tombert 50 minutes ago
          I agree. I almost feel like this should be like a flag in `free`. Like if you pass in 1 or something as a second argument (or maybe a `free_safe` function or something), it will automatically `memset` whatever it's freeing with 0's, and then do the normal freeing.
    • dmitrygr 3 hours ago
      FYI, at least in C/C++, the compiler is free to throw away assignments to any memory pointed to by a pointer if said pointer is about to be passed to free(), so depending on how you did this, no perf impact could have been because your compiler removed the assignment. This will even affect a call to memset()

      see here: https://godbolt.org/z/rMa8MbYox

      • kentonv 39 minutes ago
        I patched the free() implementation itself, not the code that calls free().

        I did, of course, test it, and anyway we now run into the "freed memory" pattern regularly when debugging (yes including optimized builds), so it's definitely working.

      • shakna 3 hours ago
        However, if you recast to volatile, the compiler will keep it:

            #include <stdlib.h>
            #include <string.h>
        
            void free(void* ptr);
            void not_free(void* ptr);
        
        
            void test_with_free(char* ptr) {
                ptr[5] = 6;
                void *(* volatile memset_v)(void *s, int c, size_t n) = memset;
                memset_v(ptr + 2, 3, 4);
                free(ptr);
            }
        
            void test_with_other_func(char* ptr) {
                ptr[5] = 6;
                void *(* volatile memset_v)(void *s, int c, size_t n) = memset;
                memset_v(ptr + 2, 3, 4);
                not_free(ptr);
            }
        • cperciva 57 minutes ago
          That code is not guaranteed to work. Declaring memset_v as volatile means that the variable has to be read, but does not imply that the function must be called; the compiler is free to compile the function call as "tmp = memset_v; if (tmp != memset) tmp(...)" relying on its knowledge that in the likely case of equality the call can be optimized away.
        • maxlybbert 2 hours ago
          Newer versions of C++ (and C, apparently) have functions so that the cast isn't necessary ( https://en.cppreference.com/w/c/string/byte/memset.html ).
  • plorkyeran 4 hours ago
    The author seems to be unaware that Mongo internally develops in a private repo and commits are published later to the public one with https://github.com/google/copybara. All of the confusion around dates is due to this.
  • computerfan494 4 hours ago
    The author of this post is incorrect about the timeline. Our Atlas clusters were upgraded days before the CVE was announced.
  • exabrial 2 hours ago
    Why is anyone using mongo for literally anything
    • nine_k 53 minutes ago
      Easy replication. I suppose it's faster than Postgres's JSONB, too.

      I would rather not use it, but I see that there are legitimate cases where MongoDB or DynamoDB is a technically appropriate choice.

    • mickael-kerjean 1 hour ago
      because it is "web scale"

      ref: https://www.youtube.com/watch?v=b2F-DItXtZs

    • Aldipower 1 hour ago
      This is a nasty ad repositorium datorum argumentation which I cannot tolerate.
  • maxrmk 6 hours ago
    How often are mongo instances exposed to the internet? I'm more of an SQL person and for those I know it's pretty uncommon, but does happen.
    • petcat 5 hours ago
      From my experience, Mongo DB's entire raison d'etre is "laziness".

      * Don't worry about a schema.

      * Don't worry about persistence or durability.

      * Don't worry about reads or writes.

      * Don't worry about connectivity.

      This is basically the entire philosophy, so it's not surprising at all that users would also not worry about basic security.

      • aragilar 4 hours ago
        Not only that, but authentication is much harder than it needs to be to set up (and is off by default).
      • winrid 4 hours ago
        Although interestingly, for all the mongo deployments I managed, the first time I saw a cluster publicly exposed without SSL was postgres :)
      • ddtaylor 2 hours ago
        Ultimate webscale!
      • Thaxll 1 hour ago
        Most of your points are wrong. Maybe only 1- is valid'ish.
    • hahahacorn 5 hours ago
      A highly cited reason for using mongo is that people would rather not figure out a schema. (N=3/3 for “serious” orgs I know using mongo).

      That sort of inclination to push off doing the right thing now to save yourself a headache down the line probably overlaps with “let’s just make the db publicly exposed” instead of doing the work of setting up an internal network to save yourself a headache down the line.

      • TZubiri 5 hours ago
        I would have hoped that there would be no important data in mongoDB.

        But now we can at least be rest assured that the important data in mongoDB is just very hard to read with the lack of schemas.

        Probably all of that nasty "schema" work and tech debt will finally be done by hackers trying to make use of that information.

    • wood_spirit 6 hours ago
      The article links to a shodan scan reporting 213K exposed instances https://www.shodan.io/search?query=Product%3A%22MongoDB%22
    • bschmidt107979 45 minutes ago
      Are you guys serious with these takes?

      You very often have both NoSQL and SQL at scale.

      NoSQL is used for high availability of data at scale - iMessage famously uses it for message threads, EA famously uses it for gaming matchmaking.

      What you do is have both SQL and NoSQL. The NoSQL is basically caches of resources for high availability. Imagine you are making a social media app... Yes of course you have a SQL database that stores all the data, but you maintain API caches of posts in NoSQL.

      Why? This gets to some of your other black vs white insults: NoSQL is typically WAY FASTER than SQL. That's why you use it. It's way faster to read a JSON file from a hard drive than it is to query a SQL database, always has been. So why not use NoSQL for EVERYTHING? Well, because you have duplicated data everywhere since it's not relational, it's just giant caches essentially. You also will get slow queries when the documents get huge.

      Anyway you need both. It's not an either/or thing. I cannot believe this many years later people do not know the purpose of SQL and NoSQL and do not understand that it is not a competition at all. You want both!

      • Capricorn2481 25 minutes ago
        What they wrote was pretty benign. They just asked how common it is for Mongo to be exposed. You seem to have taken that as a completely different statement
        • bschmidt107979 5 minutes ago
          I mean they said it's rarely used when in fact it's widely used by some of the world's biggest companies at the highest scale the internet knows. The other guy had a harsher comment sure, maybe I should duplicate my reply to them, but who knows what kinds of rules that breaks on this site lmao Happy Christmas & New Year buddy!
    • acheong08 44 minutes ago
      My university has one exposed to the internet, and it's still not patched. Everyone is on holiday and I have no idea who to contact.
    • ddtaylor 2 hours ago
      It could be because when you leave an SQL server exposed it often turns into much worse things. For example, without additional configuration, PostgreSQL will default into a configuration that can own the entire host machine. There is probably some obscure feature that allows system process management, uploading a shell script or something else that isn't disabled by default.

      The end result is "everyone" kind of knows that if you put a PostgreSQL instance up publicly facing without a password or with a weak/default password, it will be popped in minutes and you'll find out about it because the attackers are lazy and just running crypto-mine malware, etc.

    • ok123456 4 hours ago
      For a long time, the default install had it binding to all interfaces and with authentication disabled.
    • notepad0x90 3 hours ago
      often. lots of data leaks happened because of this. people spin it up in a cloud vm and forget it has a public ip all the time.
  • bschmidt107979 35 minutes ago
    Every time someone posts about NoSQL a thousand "programmers" reveal they have never had to support a lot of traffic lol
  • netsharc 1 hour ago
    > On Dec 24th, MongoDB reported they have no evidence of anybody exploiting the CVE

    Absence of evidence is not evidence of absence...

    • forrestthewoods 1 hour ago
      What would you prefer them to say?
      • perching_aix 10 minutes ago
        Evidence of no exploitations? It's usually hard to prove a negative, except when you have all the logs at your fingertips you can sift through. Unless they don't, of course. In which case the point stands: they don't actually know at this point in time, if they can even know about it at all.

        Specifically, it looks like the exflitration primitive relies on errors being emitted, and those errors are what leak the data. One wouldn't reasonably expect MongoDB to hold onto all raw traffic data flowing in and out, but would absolutely expect them to have the error logs, at least for some time back.

  • whynotmaybe 5 hours ago
    I'm still thinking about the hypothetical optimism brought by OWASP top 10 hoping that major flaws will be solved and that buffer overflow has been there since the beginning... in 2003.
    • thrwaway55 3 hours ago
      I mean giving everyone footguns and you'll find that is unavoidable forever. Thoughts and prayers to the Mongo devs until we migrate to a language that prevents this error.
  • reassess_blind 1 hour ago
    Have all Atlas clusters been auto-updated with a fix?
  • petesergeant 47 minutes ago
    > In C/C++, this doesn’t happen. When you allocate memory via `malloc()`, you get whatever was previously there.

    What would break if the compiler zero'd it first? Do programs rely on malloc() giving them the data that was there before?

  • ChrisArchitect 1 hour ago
  • fwip 45 minutes ago
    "MongoBleed Explained by an LLM"