A 40-line fix eliminated a 400x performance gap

(questdb.com)

88 points | by bluestreak 2 hours ago

4 comments

  • ot 29 minutes ago
    You can do even faster, about 8ns (almost an additional 10x improvement) by using software perf events: PERF_COUNT_SW_TASK_CLOCK is thread CPU time, it can be read through a shared page (so no syscall, see perf_event_mmap_page), and then you add the delta since the last context switch with a single rdtsc call within a seqlock.

    This is not well documented unfortunately, and I'm not aware of open-source implementations of this.

    EDIT: Or maybe not, I'm not sure if PERF_COUNT_SW_TASK_CLOCK allows to select only user time. The kernel can definitely do it, but I don't know if the wiring is there. However this definitely works for overall thread CPU time.

    • jerrinot 19 minutes ago
      That's a brilliant trick. The setup overhead and permission requirements for perf_event might be heavy for arbitrary threads, but for long-lived threads it looks pretty awesome! Thanks for sharing!
      • ot 17 minutes ago
        Yes you need some lazy setup in thread-local state to use this. And short-lived threads should be avoided anyway :)
  • jerrinot 2 hours ago
    Author here. After my last post about kernel bugs, I spent some time looking at how the JVM reports its own thread activity. It turns out that "What is the CPU time of this thread?" is/was a much more expensive question than it should be.
    • jacquesm 1 hour ago
      I don't think it is possible to talk about fractions of nanoseconds without having an extremely good idea of the stability and accuracy of your clock. At best I think you could claim there is some kind of reduction but it is super hard to make such claims in the absolute without doing a massive amount of prep work to ensure that the measured times themselves are indeed accurate. You could be off by a large fraction and never know the difference. So unless there is a hidden atomic clock involved somewhere in these measurements I think they should be qualified somehow.
      • rcxdude 1 hour ago
        Stability and accuracy, when applied to clocks, are generally about dynamic range, i.e. how good is the scale with which you are measuring time. So if you're talking about nanoseconds across a long time period, seconds or longer, then yeah, you probably should care about your clock. But when you're measuring nanoseconds out of a millisecond or microsecond, it really doesn't matter that much and you're going to be OK with the average crystal oscillator in a PC. (and if you're measuring a 10% difference like in the article, you're going to be fine with a mechanical clock as your reference if you can do the operation a billion times in a row).
        • jacquesm 46 minutes ago
          This setup is a user space program on a machine that is not exclusively dedicated to the test running all kinds of interrupts (and other tasks) left, right and center through the software under test.
    • Neywiny 1 hour ago
      Did you look into the large spread on your distributions? Some of these span multiple orders of magnitude which is interesting
      • jerrinot 1 hour ago
        Fair point. These were run on a standard dev workstation under load, which may account for the noise. I haven't done a deep dive into the outliers yet, but the distribution definitely warrants a more isolated look.
    • 6r17 1 hour ago
      Very thankful for the 1liner tldr

      edit : I had an afterthought about this because it ended up being a low quality comment ;

      Bringing up such TLDR give a lot of value to reading content, especially on HN, as it provides way more inertia and let focus on -

      reading this short form felt like that cool friend who gave you a heads up.

      • jerrinot 56 minutes ago
        I was unsure whether to post it or not so I am glad you found it useful!
        • 6r17 53 minutes ago
          I have that 10-30s time window to fill when claude might be loading some stuff ; the 1 liner is exactly what fits in that window - it makes me wonder about the original idea of twitter now that I think of it - but since it's not the same kind of content I don't bother with it.It really feels like "here is the stuff, here's more about it if you want to" - really really appreciate that form and will definitely do the same format myself
  • higherhalf 40 minutes ago
    clock_gettime() goes through vDSO, avoiding a context switch. It shows up on the flamegraph as well.
  • ee99ee 1 hour ago
    This is such a great writeup